linux-kernel - Re: [PATCH v2 1/1] printk: add __printf attributes to internal functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170525120236.GD386@jagdpanzerIV.localdomain>
Date:   Thu, 25 May 2017 21:02:36 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Nicolas Iooss <nicolas.iooss_linux@....org>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] printk: add __printf attributes to internal
 functions

On (05/25/17 13:29), Petr Mladek wrote:
> On Wed 2017-05-24 07:49:50, Nicolas Iooss wrote:
> > When compiling with -Wsuggest-attribute=format, gcc complains that some
> > functions in kernel/printk/printk_safe.c transmit their argument to
> > printf-like functions without having a printf attribute. Silence these
> > warnings by adding relevant __printf attributes.
> > 
> > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@....org>
> > Acked-by: Petr Mladek <pmladek@...e.com>
> > ---
> > v2: add __printf attribute to the definition of vprintk_nmi() which is
> > used when CONFIG_PRINTK_NMI is not defined.
> 
> Sergey, I believe that that your Reviewed-by is still valid even after
> this small update. Is that true, please?

sure. sorry about that!

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

	-ss