linux-kernel - Re: [PATCH v2 1/1] w1: Add subsystem kernel public interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <299fe87d-d0fd-6f16-2f7e-ba56096e5021@ti.com>
Date:   Thu, 25 May 2017 08:21:59 -0500
From:   "Andrew F. Davis" <afd@...com>
To:     Evgeniy Polyakov <zbr@...emap.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Sebastian Reichel <sre@...nel.org>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] w1: Add subsystem kernel public interface

On 05/25/2017 08:09 AM, Evgeniy Polyakov wrote:
> Hi everyone
> 
> 25.05.2017, 16:07, "Andrew F. Davis" <afd@...com>:
> 
>>>  Do you have a patch that does that? I don't want to accept this patch
>>>  if that never happens...
>>
>> Yes, this reorganization stems from the need to move the BQ27xxx slave
>> out, patches were posted and reviewed last cycle here[0] and will be
>> reposted when this patch is accepted. Other w1/slaves can be moved out
>> at their owners convenience if/when they wish.
> 
> Why does BQ27xxx need to move out of w1 tree?
> 

Currently we have to enable a pseudo-platform device driver in the
power/supply BQ27xxx driver, then the w1 driver has to instantiate this
platform device and then they connect and communicate by sharing
callbacks. This is rather hacky.

Other buses USB, SPI, I2C, etc. allow the client device drivers to live
with the subsystem they for whose functionality they expose (e.g an I2C
attached temp sensor goes in drivers/hwmon, not drivers/i2c).

"Need" is a bit strong, but moving this out makes things a lot cleaner
and more consistent.

Andrew