lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 May 2017 15:23:39 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Mika Westerberg <mika.westerberg@...ux.intel.com> Cc: Andreas Noever <andreas.noever@...il.com>, Michael Jamet <michael.jamet@...el.com>, Yehezkel Bernat <yehezkel.bernat@...el.com>, Lukas Wunner <lukas@...ner.de>, Amir Levy <amir.jer.levy@...el.com>, Andy Lutomirski <luto@...nel.org>, Mario.Limonciello@...l.com, Jared.Dominguez@...l.com, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 06/24] thunderbolt: Introduce thunderbolt bus and connection manager On Thu, May 18, 2017 at 05:38:56PM +0300, Mika Westerberg wrote: > Thunderbolt fabric consists of one or more switches. This fabric is > called domain and it is controlled by an entity called connection > manager. The connection manager can be either internal (driven by a > firmware running on the host controller) or external (software driver). > This driver currently implements support for the latter. > > In order to manage switches and their properties more easily we model > this domain structure as a Linux bus. Each host controller adds a domain > device to this bus, and these devices are named as domainN where N > stands for index or id of the current domain. > > We then abstract connection manager specific operations into a new > structure tb_cm_ops and convert the existing tb.c to fill those > accordingly. This makes it easier to add support for the internal > connection manager in subsequent patches. > > Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com> > Reviewed-by: Yehezkel Bernat <yehezkel.bernat@...el.com> > Reviewed-by: Michael Jamet <michael.jamet@...el.com> > --- > drivers/thunderbolt/Makefile | 2 +- > drivers/thunderbolt/domain.c | 230 +++++++++++++++++++++++++++++++++++++++ > drivers/thunderbolt/nhi.c | 31 ++++-- > drivers/thunderbolt/tb.c | 156 ++++++++++++-------------- > drivers/thunderbolt/tb.h | 70 +++++++++--- > drivers/thunderbolt/tunnel_pci.c | 9 +- > 6 files changed, 377 insertions(+), 121 deletions(-) > create mode 100644 drivers/thunderbolt/domain.c > > diff --git a/drivers/thunderbolt/Makefile b/drivers/thunderbolt/Makefile > index 5d1053cdfa54..e276a9a62261 100644 > --- a/drivers/thunderbolt/Makefile > +++ b/drivers/thunderbolt/Makefile > @@ -1,3 +1,3 @@ > obj-${CONFIG_THUNDERBOLT} := thunderbolt.o > thunderbolt-objs := nhi.o ctl.o tb.o switch.o cap.o path.o tunnel_pci.o eeprom.o > - > +thunderbolt-objs += domain.o > diff --git a/drivers/thunderbolt/domain.c b/drivers/thunderbolt/domain.c > new file mode 100644 > index 000000000000..b5bfca95415d > --- /dev/null > +++ b/drivers/thunderbolt/domain.c > @@ -0,0 +1,230 @@ > +/* > + * Thunderbolt bus support > + * > + * Copyright (C) 2017, Intel Corporation > + * Author: Mika Westerberg <mika.westerberg@...ux.intel.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include <linux/device.h> > +#include <linux/idr.h> > +#include <linux/module.h> > +#include <linux/slab.h> > + > +#include "tb.h" > + > +static DEFINE_IDA(tb_domain_ida); You forgot to clean this up in your module exit code with a call to ida_destroy(&tb_domain_ida); Yeah, it's not obvious, I've made the same mistake before :) Other than that minor thing, the bus logic looks good, nice job. thanks, greg k-h
Powered by blists - more mailing lists