linux-kernel - Re: [PATCH v2] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170525133042.GA17464@kroah.com>
Date:   Thu, 25 May 2017 15:30:42 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laura Abbott <labbott@...hat.com>,
        Robin Murphy <robin.murphy@....com>
Subject: Re: [PATCH v2] drivers: dma-mapping: Do not leave an invalid
 area->pages pointer in dma_common_contiguous_remap()

On Wed, May 03, 2017 at 03:57:48PM +0100, Catalin Marinas wrote:
> The dma_common_pages_remap() function allocates a vm_struct object and
> initialises the pages pointer to value passed as argument. However, when
> this function is called dma_common_contiguous_remap(), the pages array
> is only temporarily allocated, being freed shortly after
> dma_common_contiguous_remap() returns. Architecture code checking the
> validity of an area->pages pointer would incorrectly dereference already
> freed pointers. This has been exposed by the arm64 commit 44176bb38fa4
> ("arm64: Add support for DMA_ATTR_FORCE_CONTIGUOUS to IOMMU").
> 
> Fixes: 513510ddba96 ("common: dma-mapping: introduce common remapping functions")
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Reported-by: Andrzej Hajda <a.hajda@...sung.com>
> Acked-by: Laura Abbott <labbott@...hat.com>
> Reviewed-by: Robin Murphy <robin.murphy@....com>
> Signed-off-by: Catalin Marinas <catalin.marinas@....com>
> ---
> 
> Greg,
> 
> Please merge this patch via your tree (and therefore I haven't added
> your ack). Thanks.

I just tried to, but it doesn't apply to 4.12-rc2 :(

Can you refresh this and resend?

thanks,

greg k-h