linux-kernel - Re: [PATCH v2] um: add dummy ioremap and iounmap functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bffdbbd-a317-d9a3-88d2-d02501d2fae1@deltatee.com>
Date:   Thu, 25 May 2017 09:53:17 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Richard Weinberger <richard@....at>, linux-kernel@...r.kernel.org,
        user-mode-linux-devel@...ts.sourceforge.net
Cc:     Stephen Bates <sbates@...thlin.com>, Jeff Dike <jdike@...toit.com>,
        Al Viro <viro@...IV.linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2] um: add dummy ioremap and iounmap functions

On 25/05/17 09:48 AM, Richard Weinberger wrote:
> Which ones are failing?
> I thought we killed the problem by making CONFIG_COMPILE_TEST depend on !UML.

None, at the moment. My work is trying to add iomem support to scatter
lists and thus I want to call ioremap in scatterlist.c. That's when
things fail to build. We could put an '#ifdef HAS_IOMEM' around only the
uses, but I thought this approach was cleaner. However, if people would
rather I do that, let me know and I will.

> I was never a fan of that approach because in my opinion drivers should have
> proper dependencies, including a dependency on HAS_IOMEM.

This doesn't really work when we try to use it in a core library which
can't depend on HAS_IOMEM.

Thanks,

Logan