linux-kernel - Re: Re: [PATCH] tpm, tpm_infineon: remove useless snprintf() calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170525164416.5dn7l3eu4tkudypn@intel.com>
Date:   Thu, 25 May 2017 09:44:16 -0700
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Peter Huewe <PeterHuewe@....de>
Cc:     tpmdd-devel@...ts.sourceforge.net, jmorris@...ei.org,
        linux-security-module@...r.kernel.org,
        Marcel Selhorst <tpmdd@...horst.net>,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH] tpm, tpm_infineon: remove useless snprintf() calls

On Thu, May 25, 2017 at 07:29:05AM +0200, Peter Huewe wrote:
> > The memory copy from rodata to stack is useless.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> 
> After review, yes that should work.
> Reviewed-by: Peter Huewe <peterhuewe@....de>

Yes, the string gets stored to rodata section where it is copied to
stack :-)

Thanx!

/Jarkko