linux-kernel - Re: [PATCH] mmc: host: fix potential null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170525114638.Horde.wq7PLKWCg8CwLM5WiWj1Obm@gator4166.hostgator.com>
Date:   Thu, 25 May 2017 11:46:38 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Stefan Wahren <stefan.wahren@...e.com>
Cc:     Eric Anholt <eric@...olt.net>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        Scott Branden <sbranden@...adcom.com>,
        Ray Jui <rjui@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] mmc: host: fix potential null pointer dereference

Hi Stefan,

Quoting Stefan Wahren <stefan.wahren@...e.com>:

> Hi Gustavo,
>
>> "Gustavo A. R. Silva" <garsilva@...eddedor.com> hat am 24. Mai 2017  
>> um 01:42 geschrieben:
>>
>>
>> Null check at line 1165: if (mrq->cmd), implies that mrq->cmd might
>> be NULL.
>> Add null checks before dereferencing pointer mrq->cmd in order to avoid
>> any potential NULL pointer dereference.
>>
>> Addresses-Coverity-ID: 1408740
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>
> Tested-by: Stefan Wahren <stefan.wahren@...e.com>
>
> with a Raspberry Pi Zero.
>
> But please change the subject to make sure it's bcm2835 related:
>
> mmc: bcm2835: fix potential null pointer dereferences
>

OK, I'll send v2 shortly.

Thank you
--
Gustavo A. R. Silva