[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170525165503.GA14494@kroah.com>
Date: Thu, 25 May 2017 18:55:03 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Ranjit W <programlinuxstuff@...il.com>
Cc: sergio.paracuellos@...il.com, johannes.berg@...el.com,
luciano.coelho@...el.com, juliana.orod@...il.com,
karniksayli1995@...il.com, avraham.stern@...el.com,
claudiu.beznea@...il.com, davem@...emloft.net, edumazet@...gle.com,
tklauser@...tanz.ch, jarod@...hat.com, igor.pylypiv@...il.com,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging-next: wlan-ng: resolve checkpatch issues
On Sun, May 21, 2017 at 01:03:55AM +0530, Ranjit W wrote:
> fixing following checkpatch warning wherever possible:
> WARNING: line over 80 characters
>
> Signed-off-by: Ranjit W <programlinuxstuff@...il.com>
> ---
> drivers/staging/wlan-ng/cfg80211.c | 11 ++++++++---
> drivers/staging/wlan-ng/hfa384x.h | 21 ++++++++++++++-------
> drivers/staging/wlan-ng/p80211netdev.c | 3 ++-
> 3 files changed, 24 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 178f6f5d4613..8915c9240d1c 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -163,7 +163,8 @@ static int prism2_add_key(struct wiphy *wiphy, struct net_device *dev,
> goto exit;
>
> /* send key to driver */
> - did = DIDmib_dot11smt_dot11WEPDefaultKeysTable_key(key_index + 1);
> + did = DIDmib_dot11smt_dot11WEPDefaultKeysTable_key(key_index
> + + 1);
Ick, that looks horrible now, don't you think? checkpatch is a guide,
not a rule-that-must-always-be-followed.
There are other ways to fix this up, look at that horrible function name
for one such way to resolve it.
thanks,
greg k-h
Powered by blists - more mailing lists