linux-kernel - Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 May 2017 18:58:44 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     laurentiu.tudor@....com
Cc:     stuyoder@...il.com, devel@...verdev.osuosl.org, arnd@...db.de,
        roy.pledge@....com, linux-kernel@...r.kernel.org, agraf@...e.de,
        catalin.horghidan@....com, ioana.ciornei@....com,
        leoyang.li@....com, bharat.bhushan@....com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl
 warnings

On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tudor@....com wrote:
> From: Laurentiu Tudor <laurentiu.tudor@....com>

Your subject line is very odd, please use the 'v2' marking properly...

> 
> Remove several unneeded #includes, forward
> declarations and fix several issues reported
> by checkpatch.pl --strict, such as:
>  - kfree(NULL) is safe and check is not required
>  - macro argument reuse may cause possible side effects
>  - enclose macro params in parens to avoid precedence issues
>  - coding style

These, as always, need to be broken up into one-patch-per-type-of-thing,
you have been in the staging tree long enough to know this :(

Please do this first, then we can consider the rest of the series...

thanks,

greg k-h