linux-kernel - Re: [PATCH 0/20 V3] Misc cleanups for ipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLCiDJrgtRLF_rPBYhB5EQyaRzFdKu8OT38mFZ0DzTFtw@mail.gmail.com>
Date:   Thu, 25 May 2017 12:45:19 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Manfred Spraul <manfred@...orfullife.com>
Cc:     Michael Kerrisk <mtk.manpages@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>, 1vier1@....de,
        Davidlohr Bueso <dave@...olabs.net>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Fabian Frederick <fabf@...net.be>
Subject: Re: [PATCH 0/20 V3] Misc cleanups for ipc

On Thu, May 25, 2017 at 11:50 AM, Manfred Spraul
<manfred@...orfullife.com> wrote:
> Hi all,
>
> Updated series. The series got longer, because I merged all patches
> from Kees.
>
> Main changes are:
> - sems[] instead of sem[0].
> - Immediately use BUILD_BUG_ON()
> - Immediately move the memset() to avoid crashing with SEM_UNDO.
> - Use rcu for every security_xx_free(), even if ipc_addid() was not
>   successful

This all looks great (excepting the accidental hunk migration). I like
the change to use call_rcu(), though I still think it's overkill. ;)

Thanks for integrating my changes!

-Kees

> @Andrew: Could you add them again to your tree?
>
> @Michael:
> Should we update man semctl(2)?
> Several years ago, I did a review and found that sem_ctime is only
> for Coherent the time of the last change...
>
> http://calculix-rpm.sourceforge.net/sysvsem.html
>
> --
>         Manfred



-- 
Kees Cook
Pixel Security