[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20170525195827.14811-2-u.kleine-koenig@pengutronix.de>
Date: Thu, 25 May 2017 21:58:26 +0200
From: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
To: Kishon Vijay Abraham I <kishon@...com>
Cc: linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: [PATCH 2/3] phy: twl4030-usb: handle usb_add_phy_dev return value
usb_add_phy_dev can fail, so propagate this error instead of ignoring
that.
Fixes: 6747caa76cab ("usb: phy: twl4030: use the new generic PHY framework")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
---
drivers/phy/phy-twl4030-usb.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c
index 07cb0150d008..6aefbd55fcee 100644
--- a/drivers/phy/phy-twl4030-usb.c
+++ b/drivers/phy/phy-twl4030-usb.c
@@ -723,7 +723,10 @@ static int twl4030_usb_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "ldo init failed\n");
return err;
}
- usb_add_phy_dev(&twl->phy);
+
+ err = usb_add_phy_dev(&twl->phy);
+ if (err)
+ return err;
platform_set_drvdata(pdev, twl);
if (device_create_file(&pdev->dev, &dev_attr_vbus))
--
2.11.0
Powered by blists - more mailing lists