linux-kernel - Re: [PATCH 4.11 00/28] 4.11.1-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKv+Gu-tbAowobZeWvtrdpkKQqH2+sYvOWyAjV5BU4VctRFk9Q@mail.gmail.com>
Date:   Thu, 25 May 2017 13:06:31 -0700
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Matt Fleming <matt@...eblueprint.co.uk>
Cc:     Shuah Khan <shuahkh@....samsung.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Guenter Roeck <linux@...ck-us.net>, patches@...nelci.org,
        ben.hutchings@...ethink.co.uk,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>
Subject: Re: [PATCH 4.11 00/28] 4.11.1-stable review

On 25 May 2017 at 04:39, Matt Fleming <matt@...eblueprint.co.uk> wrote:
> On Mon, 15 May, at 11:28:16AM, Shuah Khan wrote:
>> Hi Matt,
>>
>> On 05/15/2017 08:36 AM, Matt Fleming wrote:
>> > On Fri, 12 May, at 10:01:41AM, Shuah Khan wrote:
>> >>
>> >> Greg/Matt,
>> >>
>> >> I started seeing this maybe since 4.11, so it isn't really a 4.11.1
>> >> issue, however sounds like this shouldn't be an error message, since
>> >> it is showing up on an older platform.
>> >>
>> >> efi: EFI_MEMMAP is not enabled.
>> >> efi: Failed to lookup EFI memory descriptor for 0x00000000d9e0f018
>> >>
>> >>
>> >> From 816e76129ed5fadd28e526c43397c79775194b5c Mon Sep 17 00:00:00 2001
>> >> From: Matt Fleming <matt@...eblueprint.co.uk>
>> >> Date: Mon, 29 Feb 2016 21:22:52 +0000
>> >> Subject: [PATCH] efi: Allow drivers to reserve boot services forever
>> >>
>> >> This change was introduced in Commit: 816e76129ed5fadd28e526c43397c79775194b5c
>> >>
>> >> Matt!
>> >>
>> >> Shouldn't this be a debug message?? Is this a really an error??
>> >
>> > Yes, it's most likely an error. We shouldn't be trying to reserve
>> > EFI regions if we can't find them in the memory map.
>> >
>> > Can you provide the full dmesg, please?
>> >
>>
>> Please see attached dmesg and dmidecode output. Please let me know if you need
>> any other information.
>
> Did you use git bisect to find the above commit that introduced this
> error message? Because while the error message itself was merged in
> the above commit there were no users until commit 8e80632fb23f
> ("efi/esrt: Use efi_mem_reserve() and avoid a kmalloc()").
>
> Can you apply the attached patch, boot your machine with the efi=debug
> command line option and capture the dmesg output? It doesn't look like
> your machine is booting using EFI.
>
> ---
>
> diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi/quirks.c
> index 30031d5293c4..7f942df48f42 100644
> --- a/arch/x86/platform/efi/quirks.c
> +++ b/arch/x86/platform/efi/quirks.c
> @@ -193,6 +193,7 @@ void __init efi_arch_mem_reserve(phys_addr_t addr, u64 size)
>
>         if (efi_mem_desc_lookup(addr, &md)) {
>                 pr_err("Failed to lookup EFI memory descriptor for %pa\n", &addr);
> +               WARN_ON(1);
>                 return;
>         }
>

Could this be related to the BGRT patch we have in efi/next?