linux-kernel - Re: [PATCH 2/7] RISC-V: arch/riscv Makefile and Kconfigs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-1f3c2743-64c0-4f9b-8b8c-0d4dc995b211@palmer-si-x1c4>
Date:   Wed, 24 May 2017 18:59:07 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     geert@...ux-m68k.org
CC:     albert@...ive.com
Subject:     Re: [PATCH 2/7] RISC-V: arch/riscv Makefile and Kconfigs

On Tue, 23 May 2017 03:51:24 PDT (-0700), geert@...ux-m68k.org wrote:
> Hi Palmer,
>
> On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt <palmer@...belt.com> wrote:
>> --- /dev/null
>> +++ b/arch/riscv/Kconfig
>> @@ -0,0 +1,300 @@
>
>> +config PLIC
>> +       bool "Platform-Level Interrupt Controller"
>> +       default y
>> +       help
>> +          This enables support for the PLIC chip found in standard RISC-V
>> +          systems. The PLIC is the top-most interrupt controller found in
>> +          the system, connected directly to the core complex. All other
>> +          interrupt sources (MSI, GPIO, etc) are subordinate to the PLIC.
>> +
>> +          If you don't know what to do here, say Y.
>> +
>
> I think this symbol belongs in drivers/irqchip/Kconfig, and the corresponding
> driver in drivers/irqchip/.

OK, makes sense.

  https://github.com/riscv/riscv-linux/commit/81e5c9e581c318ea99192d5c1aaf97c197e79272

I'll batch this up with all the other code review comments for a v2.