[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170525211613.GA14802@obsidianresearch.com>
Date: Thu, 25 May 2017 15:16:13 -0600
From: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc: tpmdd-devel@...ts.sourceforge.net,
linux-security-module@...r.kernel.org,
Peter Huewe <peterhuewe@....de>,
Marcel Selhorst <tpmdd@...horst.net>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] tpm: migrate pubek_show to struct tpm_buf
On Thu, May 25, 2017 at 02:11:04PM -0700, Jarkko Sakkinen wrote:
> struct tpm_chip *chip = to_tpm_chip(dev);
> + char anti_replay[20];
>
> - tpm_cmd.header.in = tpm_readpubek_header;
> - err = tpm_transmit_cmd(chip, NULL, &tpm_cmd, READ_PUBEK_RESULT_SIZE,
> + rc = tpm_buf_init(&tpm_buf, TPM_TAG_RQU_COMMAND, TPM_ORD_READPUBEK);
> + if (rc)
> + return rc;
> +
> + /* The checksum is ignored so it doesn't matter what the contents are.
> + */
> + tpm_buf_append(&tpm_buf, anti_replay, sizeof(anti_replay));
It does matter, we do not want to leak random kernel memory incase it
has something sensitive. Zero anti_replay.
> +
> - /*
> - ignore header 10 bytes
> - algorithm 32 bits (1 == RSA )
> - encscheme 16 bits
> - sigscheme 16 bits
> - parameters (RSA 12->bytes: keybit, #primes, expbit)
> - keylenbytes 32 bits
> - 256 byte modulus
> - ignore checksum 20 bytes
> - */
Not sure we should delete the comment, tpm buf does not make the parse
any clearer.
Jason
Powered by blists - more mailing lists