[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <149574798866.52617.17864487502272102012@resonance>
Date: Thu, 25 May 2017 14:33:08 -0700
From: Michael Turquette <mturquette@...libre.com>
To: Anup Patel <anup.patel@...adcom.com>,
"Rob Herring" <robh+dt@...nel.org>,
"Mark Rutland" <mark.rutland@....com>,
"Stephen Boyd" <sboyd@...eaurora.org>
Cc: "Catalin Marinas" <catalin.marinas@....com>,
"Will Deacon" <will.deacon@....com>, "Ray Jui" <rjui@...adcom.com>,
"Scott Branden" <sbranden@...adcom.com>,
"Jon Mason" <jonmason@...adcom.com>,
"Florian Fainelli" <f.fainelli@...il.com>,
"Oza Pawandeep" <oza.oza@...adcom.com>,
"Srinath Mannam" <srinath.mannam@...adcom.com>,
"Pramod Kumar" <pramod.kumar@...adcom.com>,
"Sandeep Tripathy" <sandeep.tripathy@...adcom.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH v4 03/11] clk: bcm: Add clocks for Stingray SOC
Hello Anup,
Quoting Anup Patel (2017-05-22 04:58:19)
> +#include <linux/kernel.h>
> +#include <linux/err.h>
> +#include <linux/clk-provider.h>
> +#include <linux/io.h>
> +#include <linux/of.h>
> +#include <linux/of_address.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
Are all of those headers really needed?
> +CLK_OF_DECLARE(sr_genpll3_clk, "brcm,sr-genpll3",
> + sr_genpll3_clk_init);
Why use CLK_OF_DECLARE here? You've got a proper platform driver here.
Regards,
Mike
Powered by blists - more mailing lists