linux-kernel - Re: Why does callback irq_startup in struct irq_chip return _unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 May 2017 09:13:06 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Heiner Kallweit <hkallweit1@...il.com>
cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Why does callback irq_startup in struct irq_chip return _unsigned_
 int ?

Heiner,

On Thu, 25 May 2017, Heiner Kallweit wrote:
> just by chance I noticed that callback irq_startup in struct irq_chip
> returns an unsigned int.
> This doesn't seem to make sense as the result is a normal retval which
> is casted to a signed int in function irq_startup() anyway.
> 
> Is there any specific reason for this or is it simply a bug?

/me scratches head.

IIRC then it was made unsigned int because that function cannot fail, but
can return that an interrupt was pending.

So if at all the thing should be 'bool'.

Thanks,

	tglx