linux-kernel - Re: [GIT PULL (RESEND)] ARM: uniphier: UniPhier fixes for v4.12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170525235902.GA25387@localhost>
Date:   Thu, 25 May 2017 16:59:02 -0700
From:   Olof Johansson <olof@...om.net>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     arm@...nel.org, Arnd Bergmann <arnd@...db.de>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        masahiroy@...nel.org, ulf.hansson@...aro.org,
        Piotr Sroka <piotrs@...ence.com>
Subject: Re: [GIT PULL (RESEND)] ARM: uniphier: UniPhier fixes for v4.12

On Mon, May 22, 2017 at 11:03:49AM +0900, Masahiro Yamada wrote:
> Hi Arnd, Olof,
> 
> Last week, I thought I found a problem in my pull request,
> but it turned out my misunderstanding.
> 
> So, my pull request I sent is OK.
> I am re-sending this request mail for clarification.
> 
> Here are some ARM UniPhier SoC fixes for v4.12.
> Due to the eMMC driver update, PHY parameters must be specified
> via DT to make the eMMC controller work again.

That's not good, that's a regression in behavior. The driver should
have a fallback when the properties are not present to avoid regressions
like these.

Please work with the driver maintainer to either get them to revert
their change that regresses you, or promptly fix it appropriately with
fallback values.

Also, the driver changes were commited back in March, with plenty of time
to land DT changes well before the merge window. Waiting until the merge
window is closed is not appropriate -- this should have come in earlier.

-Olof