linux-kernel - Re: [PATCH] platform/x86: intel_pmc_ipc: Mark ipc_data_readb() as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 May 2017 12:53:52 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Zha Qipeng <qipeng.zha@...el.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Alan Cox <gnomes@...rguk.ukuu.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH] platform/x86: intel_pmc_ipc: Mark ipc_data_readb() as __maybe_unused

On Fri, May 26, 2017 at 1:15 AM, Matthias Kaehlcke <mka@...omium.org> wrote:
> The function is currently not used, however it is part of the API and
> might be used in the future. Adding the attribute fixes the following
> warning when building with clang:
>
>     drivers/platform/x86/intel_pmc_ipc.c:189:18: error: unused function
>         'ipc_data_readb' [-Werror,-Wunused-function]
>

Pushed to testing, thanks!

> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
>  drivers/platform/x86/intel_pmc_ipc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c
> index e4d4dfe3e1d1..bb792a52248b 100644
> --- a/drivers/platform/x86/intel_pmc_ipc.c
> +++ b/drivers/platform/x86/intel_pmc_ipc.c
> @@ -186,7 +186,7 @@ static inline void ipc_data_writel(u32 data, u32 offset)
>         writel(data, ipcdev.ipc_base + IPC_WRITE_BUFFER + offset);
>  }
>
> -static inline u8 ipc_data_readb(u32 offset)
> +static inline u8 __maybe_unused ipc_data_readb(u32 offset)
>  {
>         return readb(ipcdev.ipc_base + IPC_READ_BUFFER + offset);
>  }
> --
> 2.13.0.219.gdb65acc882-goog
>



-- 
With Best Regards,
Andy Shevchenko