linux-kernel - [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.21.1705260343290.1853@joy.test>
Date:   Fri, 26 May 2017 03:48:34 -0700 (PDT)
From:   Richard Narron <comet.berkeley@...il.com>
To:     linux-kernel@...r.kernel.org
cc:     Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        Andries Brouwer <aeb@....nl>
Subject: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not
 recognized

The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD
and NetBSD partitions and does a reasonable job picking out OpenBSD
and NetBSD UFS subpartitions.

But for FreeBSD the subpartitions are always "bad".

     Kernel: <bsd:bad subpartition - ignored

Though all 3 of these BSD systems use UFS as a file system, only
FreeBSD uses relative start addresses in the subpartition
declarations.

The following patch fixes this for FreeBSD partitions and leaves
the code for OpenBSD and NetBSD intact:

Cc: Jens Axboe <axboe@...nel.dk>
Cc: Andries Brouwer <aeb@....nl>
Cc: linux-block@...r.kernel.org
Reviewed-by: Christoph Hellwig <hch@....de>
Signed-off-by: Richard Narron <comet.berkeley@...il.com>
---
Changelog v2->v3:
- Add Cc:
Changelog v1->v2: - Improve style, use +=
---
  block/partitions/msdos.c | 2 ++
  1 file changed, 2 insertions(+)

--- a/block/partitions/msdos.c	2015-12-27 18:17:37.000000000 -0800
+++ b/block/partitions/msdos.c	2015-12-29 10:44:25.813773357 -0800
@@ -300,6 +300,8 @@ static void parse_bsd(struct parsed_part
  			continue;
  		bsd_start = le32_to_cpu(p->p_offset);
  		bsd_size = le32_to_cpu(p->p_size);
+		if (memcmp(flavour, "bsd\0", 4) == 0)
+			bsd_start += offset;
  		if (offset == bsd_start && size == bsd_size)
  			/* full parent partition, we have it already */
  			continue;