linux-kernel - Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bb8d972-6535-1611-8fa7-f5fe89760531@siemens.com>
Date:   Fri, 26 May 2017 15:04:26 +0200
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Alexandre Courbot <gnurou@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-serial@...r.kernel.org, linux-gpio@...r.kernel.org,
        Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Sascha Weisenberger <sascha.weisenberger@...mens.com>
Subject: Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output

Greg,

On 2017-05-13 09:28, Jan Kiszka wrote:
> This is the safe default for GPIOs with unknown external wiring.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> ---
>  drivers/tty/serial/8250/8250_exar.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
> index 1270ff163f63..b4fa585156c7 100644
> --- a/drivers/tty/serial/8250/8250_exar.c
> +++ b/drivers/tty/serial/8250/8250_exar.c
> @@ -177,13 +177,13 @@ static void setup_gpio(u8 __iomem *p)
>  	writeb(0x00, p + UART_EXAR_MPIOLVL_7_0);
>  	writeb(0x00, p + UART_EXAR_MPIO3T_7_0);
>  	writeb(0x00, p + UART_EXAR_MPIOINV_7_0);
> -	writeb(0x00, p + UART_EXAR_MPIOSEL_7_0);
> +	writeb(0xff, p + UART_EXAR_MPIOSEL_7_0);
>  	writeb(0x00, p + UART_EXAR_MPIOOD_7_0);
>  	writeb(0x00, p + UART_EXAR_MPIOINT_15_8);
>  	writeb(0x00, p + UART_EXAR_MPIOLVL_15_8);
>  	writeb(0x00, p + UART_EXAR_MPIO3T_15_8);
>  	writeb(0x00, p + UART_EXAR_MPIOINV_15_8);
> -	writeb(0x00, p + UART_EXAR_MPIOSEL_15_8);
> +	writeb(0xff, p + UART_EXAR_MPIOSEL_15_8);
>  	writeb(0x00, p + UART_EXAR_MPIOOD_15_8);
>  }
>  
> 

Please drop from this tty-next, it may break Commtech adapters. I have
an update ready.

I may also send a fix on top if that is preferred, just let me know.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux