linux-kernel - Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 May 2017 07:31:52 -0700
From:   Joe Perches <joe@...ches.com>
To:     Richard Narron <comet.berkeley@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        Andries Brouwer <aeb@....nl>
Subject: Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are
 not recognized

On Fri, 2017-05-26 at 03:48 -0700, Richard Narron wrote:
> The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD
> and NetBSD partitions and does a reasonable job picking out OpenBSD
> and NetBSD UFS subpartitions.
> 
> But for FreeBSD the subpartitions are always "bad".
> 
>      Kernel: <bsd:bad subpartition - ignored
[]
>   block/partitions/msdos.c | 2 ++
[]
> @@ -300,6 +300,8 @@ static void parse_bsd(struct parsed_part
>   			continue;
>   		bsd_start = le32_to_cpu(p->p_offset);
>   		bsd_size = le32_to_cpu(p->p_size);
> +		if (memcmp(flavour, "bsd\0", 4) == 0)

Weird code.  Why not:

		if (strcmp(flavor, "bsd") == 0)