linux-kernel - Re: [tip:timers/core] mmtimer: Remove the SGI SN2 mmtimer driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 May 2017 07:43:42 -0700
From:   Joe Perches <joe@...ches.com>
To:     tglx@...utronix.de, hpa@...or.com, hch@....de, mike.travis@....com,
        mingo@...nel.org, sivanich@....com, linux-kernel@...r.kernel.org,
        linux-tip-commits@...r.kernel.org
Subject: Re: [tip:timers/core] mmtimer: Remove the SGI SN2 mmtimer driver

On Fri, 2017-05-26 at 03:58 -0700, tip-bot for Christoph Hellwig wrote:
> Commit-ID:  07903ada96139ced48f2f893fe57a26a8fbc6043

Couple trivial comments:

> mmtimer: Remove the SGI SN2 mmtimer driver
[]
>  drivers/char/mmtimer.c    | 858 ----------------------------------------------
>  include/uapi/linux/time.h |   6 +-
[]
> diff --git a/drivers/char/mmtimer.c b/drivers/char/mmtimer.c
> deleted file mode 100644
> index 0e7fcb0..0000000
> --- a/drivers/char/mmtimer.c
> +++ /dev/null
> @@ -1,858 +0,0 @@
> -/*

[ etc...]

In the future, please use git format-patch -M to avoid
listing the
contents of the file deletion.

> diff --git a/include/uapi/linux/time.h b/include/uapi/linux/time.h
[]
> @@ -54,7 +54,11 @@ struct itimerval {
>  #define CLOCK_BOOTTIME			7
>  #define CLOCK_REALTIME_ALARM		8
>  #define CLOCK_BOOTTIME_ALARM		9
> -#define CLOCK_SGI_CYCLE			10	/* Hardware specific */
> +/*
> + * The driver implementing this got removed. The clock ID is kept as a
> + * place holder. Do not reuse!
> + */
> +#define CLOCK_SGI_CYCLE			10
>  #define CLOCK_TAI			11
>  
>  #define MAX_CLOCKS			16

Here the "this" comment is a bit ambiguous.

It might be better to rename CLOCK_SGI_CYCLE as well.
Maybe something like CLOCK_SGI_CYCLE_DELETED_DRIVER_DONT_REUSE.