linux-kernel - arm64 test_user_copy crash on copy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1tyU8J4VEWVwLOHWM+of9bnWvm+SXBxkfsZA7yfEei9A@mail.gmail.com>
Date:   Fri, 26 May 2017 17:24:47 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     Kees Cook <keescook@...omium.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>
Subject: arm64 test_user_copy crash on copy_from_user(uptr, kptr, size)

A kselftest run on arm64 on an older 4.4.y stable kernel ran into an
unexpectedly trapping user space access:

[ 1277.857738] Internal error: Accessing user space memory outside
uaccess.h routines: 96000045 [#1] PREEMPT SMP

Apparently the same thing happens on x86 as well, and it still happens on
the latest kernels, see https://bugs.linaro.org/show_bug.cgi?id=3011

The problem here is this test

       ret |= test(!copy_from_user(bad_usermem, (char __user *)kmem,
                                   PAGE_SIZE),
                   "illegal reversed copy_from_user passed");

where the destination kernel pointer intentionally points into user space
memory, while copy_from_user checks the second argument for being
a valid user space, which it also is not.:

static inline unsigned long __must_check copy_from_user(void *to,
const void __user *from, unsigned long n)
{
        unsigned long res = n;
        kasan_check_write(to, n);

        if (access_ok(VERIFY_READ, from, n)) {
                check_object_size(to, n, false);
                res = __arch_copy_from_user(to, from, n);
        }
        if (unlikely(res))
                memset(to + (n - res), 0, res);
        return res;
}

The memset here will now try to clear user space data, and the
architecture notices that the fault did not come from a proper
uaccess function.

I think this will only happen when CONFIG_ARM64_PAN,
 X86_SMAP or an equivalent feature on another architecture is
enabled, otherwise we just do the access anyway. I don't have
a good idea for avoiding the problem though, other than
removing the specific test that causes it.

       Arnd