linux-kernel - Re: [PATCH 3/8] x86: use long long for 64-bit atomic ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACT4Y+ZDERPOOHy0Gdik1a48+2qJJw+yVN+_PU7XzZKPYb0fXg@mail.gmail.com>
Date:   Fri, 26 May 2017 21:29:23 +0200
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Will Deacon <will.deacon@....com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        kasan-dev <kasan-dev@...glegroups.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH 3/8] x86: use long long for 64-bit atomic ops

On Tue, Mar 28, 2017 at 11:32 PM, Matthew Wilcox <willy@...radead.org> wrote:
> On Tue, Mar 28, 2017 at 06:15:40PM +0200, Dmitry Vyukov wrote:
>> @@ -193,12 +193,12 @@ static inline long atomic64_xchg(atomic64_t *v, long new)
>>   * @a: the amount to add to v...
>>   * @u: ...unless v is equal to u.
>>   *
>> - * Atomically adds @a to @v, so long as it was not @u.
>> + * Atomically adds @a to @v, so long long as it was not @u.
>>   * Returns the old value of @v.
>>   */
>
> That's a clbuttic mistake!
>
> https://www.google.com/search?q=clbuttic


Fixed in v2:
https://groups.google.com/forum/#!topic/kasan-dev/3PoGcuMku-w
Thanks