linux-kernel - Re: [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support for rk3228

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a36f756f-9454-adf7-18aa-3e46c3d79cde@rock-chips.com>
Date:   Fri, 26 May 2017 11:38:57 +0800
From:   "David.Wu" <david.wu@...k-chips.com>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     linus.walleij@...aro.org, huangtao@...k-chips.com,
        dianders@...omium.org, linux-rockchip@...ts.infradead.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support
 for rk3228

Hi Heiko,

在 2017/5/26 5:12, Heiko Stuebner 写道:
> Requiring developers to calculate this pin-bit-value for each bank
> is cumbersome and error-prone. With the routes-struct known in
> the driver (see above and below), you can keep the the value element
> in rockchip_pin_bank, but calculate the per-bank value dynamically
> when the bank gets created.
> 
> For example in rockchip_pinctrl_get_soc_data just parse the route-struct
> and calculate that value when the driver probes.
> 
> This reduces possible errors and also spares us the clutter of all the
> additional PIN_BANK_* defines.

It is good to calculate the per-bank value dynamically, Thanks.☺