linux-kernel - Re: [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c95ae14-06a7-d3c2-aabb-1e164eb6b6e9@roeck-us.net>
Date:   Fri, 26 May 2017 18:53:10 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Murilo Opsfelder Araujo <mopsfelder@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     linux-watchdog@...r.kernel.org, Wim Van Sebroeck <wim@...ana.be>,
        Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS
 dependencies

On 05/26/2017 06:22 PM, Murilo Opsfelder Araujo wrote:
> drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c,
> which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without
> setting CONFIG_PPC_RTAS throws the following errors:
> 
>      ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
>      ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
>      ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
>      ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
>      ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!
> 
> This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and
> CONFIG_PPC_RTAS was not set. Logs are here:
> 
>      http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
> 
> This patch fixes the issue by selecting CONFIG_PPC_RTAS when
> CONFIG_WATCHDOG_RTAS is set.
> 
> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@...il.com>
> ---
>   drivers/watchdog/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 8b9049d..5d872145 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1689,6 +1689,7 @@ config MEN_A21_WDT
>   config WATCHDOG_RTAS
>   	tristate "RTAS watchdog"
>   	depends on PPC_RTAS || (PPC64 && COMPILE_TEST)
> +	select PPC_RTAS

This can not at the same time depend on PPC_RTAS and select it.
Guess we'll have to drop COMPILE_TEST entirely.

Guenter