linux-kernel - Re: [PATCH] genirq: Check irq disabled & masked states in irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <592905F7.4010803@rock-chips.com>
Date:   Sat, 27 May 2017 12:52:07 +0800
From:   jeffy <jeffy.chen@...k-chips.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     linux-kernel@...r.kernel.org, briannorris@...omium.org,
        dianders@...omium.org, tfiga@...omium.org
Subject: Re: [PATCH] genirq: Check irq disabled & masked states in irq_shutdown

Hi Thomas,

On 05/26/2017 09:20 PM, Thomas Gleixner wrote:
> On Fri, 26 May 2017, Jeffy Chen wrote:
>
>> If irq is already disabled and masked, we would hit a unbalanced irq
>> shutdown/disable/mask when freeing it.
>
> Errr? What exactly is unbalanced? None of the called functions has any
> counter or whatever.
>
> Can you please explain what you are trying to fix?

sorry, i'll try to rewrite the commit message.

for example when a driver(drivers/net/wireless/marvell/mwifiex/main.c) 
try to do these:

devm_request_irq->irq_startup->irq_enable
disable_irq                                     <-- disabled and masked
devm_free_irq->irq_shutdown                     <-- disable it again

and the pinctrl-rockchip driver would enable/disable gpio clk in 
irq_enable/irq_disable, so it would try to disable a disabled clk(due to 
unbalanced irq disable)


>
> Thanks,
>
> 	tglx
>
>
>