lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 27 May 2017 17:42:01 +0800 From: Guodong Xu <guodong.xu@...aro.org> To: Javier Martinez Canillas <javier@...hile0.org> Cc: Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, "xuwei (O)" <xuwei5@...ilicon.com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Kevin Hilman <khilman@...libre.com>, Arnd Bergmann <arnd@...db.de>, Gregory Clement <gregory.clement@...e-electrons.com>, Olof Johansson <olof@...om.net>, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, Masahiro Yamada <yamada.masahiro@...ionext.com>, Riku Voipio <riku.voipio@...aro.org>, Thierry Reding <treding@...dia.com>, Krzysztof Kozlowski <krzk@...nel.org>, Eric Anholt <eric@...olt.net>, damm+renesas@...nsource.se, Ard Biesheuvel <ard.biesheuvel@...aro.org>, Linus Walleij <linus.walleij@...aro.org>, Geert Uytterhoeven <geert+renesas@...der.be>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Linux Kernel <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "hw Wang(Xiaoyin)" <hw.wangxiaoyin@...ilicon.com> Subject: Re: [PATCH 4/6] regulator: hi6421v530: add driver for hi6421v530 voltage regulator On Fri, May 26, 2017 at 8:13 PM, Javier Martinez Canillas <javier@...hile0.org> wrote: > Hello Guodong, > > On Fri, May 26, 2017 at 8:35 AM, Guodong Xu <guodong.xu@...aro.org> wrote: >> From: Wang Xiaoyin <hw.wangxiaoyin@...ilicon.com> >> > > [snip] > >> >> +config REGULATOR_HI6421V530 >> + tristate "HiSilicon Hi6421v530 PMIC voltage regulator support" > > The Kconfig symbol is tristate so the driver can be built as a module... > >> + >> +static struct platform_driver hi6421v530_regulator_driver = { >> + .driver = { >> + .name = "hi6421v530-regulator", >> + }, >> + .probe = hi6421v530_regulator_probe, >> +}; >> +module_platform_driver(hi6421v530_regulator_driver); > > ... but the driver doesn't have a platform device ID table nor export > it as a module alias using MODULE_DEVICE_TABLE(). > I will add that. Thanks for your review. -Guodong > That means that if built as a module, it won't be autoloaded when the > "hi6421v530-regulator" device is registered by the MFD driver. > >> + >> +MODULE_AUTHOR("Wang Xiaoyin <hw.wangxiaoyin@...ilicon.com>"); >> +MODULE_DESCRIPTION("Hi6421v530 regulator driver"); >> +MODULE_LICENSE("GPL v2"); > > Alternative you can add a MODULE_ALIAS(). > > Best regards, > Javier
Powered by blists - more mailing lists