linux-kernel - Re: [PATCH] platform/x86: dell-wmi: Add a comment explaining the 0xb2 magic number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfWtoJYQqs-ZY38A6MSMmJVpNF1AhPFDrsz5z=WfZk=hw@mail.gmail.com>
Date:   Sat, 27 May 2017 13:39:46 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Darren Hart <dvhart@...radead.org>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Matthew Garrett <mjg59@...f.ucam.org>,
        Pali Rohár <pali.rohar@...il.com>,
        Andy Shevchenko <andy@...radead.org>
Subject: Re: [PATCH] platform/x86: dell-wmi: Add a comment explaining the 0xb2
 magic number

On Sat, May 27, 2017 at 8:15 AM, Darren Hart <dvhart@...radead.org> wrote:
> From: Andy Lutomirski <luto@...nel.org>
>
> The hotkey table is 0xb2, add a comment for clarity.
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Suggested-by: Darren Hart <dvhart@...radead.org>
> Signed-off-by: Andy Lutomirski <luto@...nel.org>
> Cc: Matthew Garrett <mjg59@...f.ucam.org>
> Cc: "Pali Rohár" <pali.rohar@...il.com>
> Cc: Andy Shevchenko <andy@...radead.org>
> Signed-off-by: Darren Hart (VMware) <dvhart@...radead.org>
> ---
>  drivers/platform/x86/dell-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 8a64c79..24467b1 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -449,6 +449,7 @@ static void __init handle_dmi_entry(const struct dmi_header *dm,
>         if (results->err || results->keymap)
>                 return;         /* We already found the hotkey table. */
>
> +       /* The Dell hotkey table is type 0xB2.  Scan until we find it. */
>         if (dm->type != 0xb2)
>                 return;
>
> --
> 2.9.4
>



-- 
With Best Regards,
Andy Shevchenko