linux-kernel - Re: [PATCH 1/2] nvme: Wait at least 6000ms before entering the deepest idle state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrXc3da8q-7ZYrh3v+fk1CbeTXqOdoPTfDbb4h=G+R+Tdg@mail.gmail.com>
Date:   Sat, 27 May 2017 09:08:23 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Andy Lutomirski <luto@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        Sagi Grimberg <sagi@...mberg.me>,
        Keith Busch <keith.busch@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        linux-nvme <linux-nvme@...ts.infradead.org>
Subject: Re: [PATCH 1/2] nvme: Wait at least 6000ms before entering the
 deepest idle state

On Fri, May 26, 2017 at 1:52 AM, Christoph Hellwig <hch@....de> wrote:
> On Wed, May 24, 2017 at 03:06:30PM -0700, Andy Lutomirski wrote:
>> This should at least make vendors less nervous about Linux's APST
>> policy.  I'm not aware of any concrete bugs it would fix (although I
>> was hoping it would fix the Samsung/Dell quirk).
>>
>> Cc: stable@...r.kernel.org # v4.11
>
> Just following a somewhat odd and arbitray policy from another driver
> that doesn't fix anything by itself certainly isn't stable material.

Fair enough.  The Cc: stable should certainly be dropped.

>
> And to be honest I'm not sure what applying it will gain us at all.

I'd be fine with skipping this patch entirely at least until we find
some evidence that it solves a problem instead.