[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VezZESJQk4kacSk3OstewTa6OFvyGDY0ogyP3dsqUSVqA@mail.gmail.com>
Date: Sat, 27 May 2017 19:35:38 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Douglas Anderson <dianders@...omium.org>
Cc: Mark Brown <broonie@...nel.org>, Vinod Koul <vinod.koul@...el.com>,
Matthias Kaehlcke <mka@...omium.org>,
Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, colin.king@...onical.com,
o-takashi@...amocchi.jp, sebastien.guiriec@...el.com,
ALSA Development Mailing List <alsa-devel@...a-project.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] ASoC: Intel: sst: Delete sst_save_shim64(); saved
regs are never used
On Fri, May 26, 2017 at 7:34 PM, Douglas Anderson <dianders@...omium.org> wrote:
> In commit 9a075265c6dc ("ASoC: Intel: sst: Remove unused function
> sst_restore_shim64()"), we deleted the sst_restore_shim64() since it
> was never used. ...but a quick look at the code shows that we should
> also be able to remove the sst_save_shim64() function and the
> structure members we were storing data in.
>
> Note that the saving code (and the comments talking about how
> important it is to do the save) has been around since
> commit 336cfbb05edf ("ASoC: Intel: mrfld- add ACPI module").
While I like "-" statistics, the below I think should be preserved if
it's repeating real registers layout.
> struct sst_shim_regs64 {
> - u64 csr;
> u64 pisr;
> u64 pimr;
> u64 isrx;
> u64 isrd;
> - u64 imrx;
> u64 imrd;
> u64 ipcx;
> u64 ipcd;
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists