linux-kernel - Re: [PATCH v4 1/1] x86, relocs: add printf attribute to die()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 27 May 2017 22:28:03 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86 <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/1] x86, relocs: add printf attribute to die()

On Wed, May 17, 2017 at 9:37 AM, Nicolas Iooss
<nicolas.iooss_linux@....org> wrote:
> Hello,
>
> The patch I sent a few months ago still applies cleanly on top of
> 4.12-rc1. What should I do in order to get it merged in 4.13?
>
> In case you no longer have my initial email, the patch has been
> archived in https://patchwork.kernel.org/patch/9604651/ .

Avoid top postings, please.

Looking into patch I see the following
1) the constify part is better to be a separate patch;
2) shouldn't be specifier '%ju' applied?

>>>> Isn't "(u64)" shorter to write?
>>>
>>> u64 does not seem to be defined in this file right now. Adding
>>> "#include <linux/types.h>" defines u64 and __u64 in the following way:
>>> - "typedef uint64_t u64;" from tools/include/linux/types.h
>>> - "typedef unsigned long long __u64;" from /usr/include/asm-generic/int-ll64.h
>>>
>>> uint64_t is unsigned long on x86-64 and gcc complains when using %llu
>>> on such a type, so using a cast to u64 forces using PRIu64 too.

-- 
With Best Regards,
Andy Shevchenko