linux-kernel - Re: [PATCH 1/2] kstrtox: delete end-of-string test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcEjaWNAKi9=m0QyybG=ffy0VXFFN-5OLu8iPwzt+z5RA@mail.gmail.com>
Date:   Sat, 27 May 2017 22:39:03 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] kstrtox: delete end-of-string test

On Sun, May 14, 2017 at 10:37 PM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> Standard "while (*s)" test is unnecessary because NUL won't pass
> valid-digit test anyway. Save one branch per parsed character.

> -       while (*s) {
> +       while (1) {

In such cases I prefer

do {} while ();

Since it makes easier to reader to catch that the loop is going at
least once (and less error prone (1) vs. (l) depending on font in
use).

...however, I see that patch is already applied.

-- 
With Best Regards,
Andy Shevchenko