linux-kernel - Re: [PATCH v3 3/4] dt-bindings: power: tps65217_charger: add NTC type for battery temperature measurement.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 27 May 2017 22:14:04 +0200
From:   Enric Balletbo Serra <eballetbo@...il.com>
To:     Liam Breck <liam@...workimprov.net>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux-pm@...r.kernel.org,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Liam Breck <kernel@...workimprov.net>
Subject: Re: [PATCH v3 3/4] dt-bindings: power: tps65217_charger: add NTC type
 for battery temperature measurement.

2017-05-26 23:26 GMT+02:00 Liam Breck <liam@...workimprov.net>:
> Hi Enric,
>
> On Fri, May 26, 2017 at 4:04 AM, Enric Balletbo i Serra
> <enric.balletbo@...labora.com> wrote:
>> The TS pin of the TPS56217 connects to the NTC resistor in the battery
>> pack. By default the device is setup to support a 10-kohm but can also
>> be configured to support a 100-kohm. Add a propietry to configure the
>> connected NTC resistor. Therefore, the charger would get the wrong
>> temperature information.
>
> This also needs a monitored-battery property, and a battery node in
> the example. See https://patchwork.kernel.org/patch/9710803/
>

Right I'll add the property in v4.

>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
>> ---
>> Changes since v2:
>>  - Requested by Sebastian Reichel
>>    - Get rid of common properties and only maintain ntc-type.
>> Changes since v1:
>>  - None
>>
>>  .../devicetree/bindings/power/supply/tps65217_charger.txt          | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/power/supply/tps65217_charger.txt b/Documentation/devicetree/bindings/power/supply/tps65217_charger.txt
>> index a11072c..851f5c7 100644
>> --- a/Documentation/devicetree/bindings/power/supply/tps65217_charger.txt
>> +++ b/Documentation/devicetree/bindings/power/supply/tps65217_charger.txt
>> @@ -6,6 +6,12 @@ Required Properties:
>>               Should be <0> for the USB charger and <1> for the AC adapter.
>>  -interrupt-names: Should be "USB" and "AC"
>>
>> +Optional properties:
>> +-ti,ntc-type: set the NTC type for battery temperature measurement. The value
>> +       must be 0 or 1, where:
>> +         0 – 100k (curve 1, B = 3960)
>> +         1 – 10k  (curve 2, B = 3480) (default)
>> +
>>  This node is a subnode of the tps65217 PMIC.
>>
>>  Example:
>> @@ -14,4 +20,5 @@ Example:
>>                 compatible = "ti,tps65217-charger";
>>                 interrupts = <0>, <1>;
>>                 interrupt-names = "USB", "AC";
>> +               ti,ntc-type = <1>;
>>         };
>> --
>> 2.9.3
>>