linux-kernel - Re: [PATCH] perf/core: Remove unused function perf_cgroup_event_cgrp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=WV_dpN+dEy7pNP1K3A-0Q1dg0XnasvZc=DkD5pEHkAPQ@mail.gmail.com>
Date:   Fri, 26 May 2017 15:46:56 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf/core: Remove unused function perf_cgroup_event_cgrp_time()

Hi,

On Tue, May 23, 2017 at 2:51 PM, Matthias Kaehlcke <mka@...omium.org> wrote:
> The function was added by commit e5d1367f17ba ("perf: Add cgroup
> support") in 2011 and hasn't been used since then. Removing it fixes the
> following warning when building with clang:
>
>     kernel/events/core.c:696:19: error: unused function
>         'perf_cgroup_event_cgrp_time' [-Werror,-Wunused-function]
>
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
>  kernel/events/core.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 6e75a5c9412d..9058fc7ca1fb 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -925,11 +925,6 @@ static inline int is_cgroup_event(struct perf_event *event)
>         return 0;
>  }
>
> -static inline u64 perf_cgroup_event_cgrp_time(struct perf_event *event)
> -{
> -       return 0;
> -}
> -
>  static inline void update_cgrp_time_from_event(struct perf_event *event)
>  {
>  }

Definitely seems like no reason to keep this around.  FWIW:

Reviewed-by: Douglas Anderson <dianders@...omium.org>