linux-kernel - Re: [PATCH] clocksource/drivers/fttmr010: Fix aspeed-2500 initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaTGnPCc16+gH9v7XwEj79FogU1uMvziRUXndPDpfwhbw@mail.gmail.com>
Date:   Sun, 28 May 2017 15:56:23 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Andrew Jeffery <andrew@...id.au>, Joel Stanley <joel@....id.au>,
        Ryan Chen <ryan_chen@...eedtech.com>,
        Mark Rutland <mark.rutland@....com>,
        Jonas Jensen <jonas.jensen@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "open list:CLOCKSOURCE, CLOCKEVENT DRIVERS" 
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clocksource/drivers/fttmr010: Fix aspeed-2500 initialization

On Fri, May 26, 2017 at 10:48 AM, Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:

> The recent changes made the fttmr010 to be more generic and support different
> timers with a very few differences like moxart or aspeed.
>
> The aspeed timer uses a countdown and there is a test against the aspeed2400
> compatible string to set a flag.
>
> With the previous patch, we added the aspeed2500 compatible string but without
> taking care of setting the countdown flag.
>
> Fix this by specifiying a init function and pass the aspeed flag to a common
> init function.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>

Sorry for the mistake :(
I don't have the Aspeed systems myself but I bet this works.

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij