linux-kernel - Re: [PATCH] scripts/gdb: make lx-dmesg command work (reliably)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <346a4a29-5e49-5ac2-24be-667c641b0e56@siemens.com>
Date:   Sun, 28 May 2017 18:29:58 +0200
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     André Draszik <git@...red.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kieran Bingham <kieran@...uared.org.uk>
Subject: Re: [PATCH] scripts/gdb: make lx-dmesg command work (reliably)

On 2017-05-27 16:01, Andy Shevchenko wrote:
> On Fri, May 26, 2017 at 2:12 PM, Jan Kiszka <jan.kiszka@...mens.com> wrote:
>> On 2017-05-26 13:04, André Draszik wrote:
> 
>>> +        log_buf_addr = int(str(gdb.parse_and_eval("'printk.c'::log_buf")).split()[0], 16)
>>
>> Overlong line. Please stay pep8 compliant.
> 
> What I heard from colleague of mine couple of years ago, they (their
> team) moved to 100 characters in Python scripts because of somehow
> stupid recommendations from last century.

Well, it happens to be in line with the kernel preference for C code. We
can discuss a different style when the kernel relaxes its own. ;)

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux