linux-kernel - Re: [PATCH 1/3] cfq-iosched: Mark cfq_clear_cfqq_*() as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170528074952.GA22193@infradead.org>
Date:   Sun, 28 May 2017 00:49:52 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
        linux-block@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH 1/3] cfq-iosched: Mark cfq_clear_cfqq_*() as
 __maybe_unused

On Fri, May 26, 2017 at 02:22:35PM -0700, Matthias Kaehlcke wrote:
> This fixes the following warning when building with clang:
> 
>     block/cfq-iosched.c:449:1: error: unused function 'cfq_clear_cfqq_sync'
>         [-Werror,-Wunused-function]
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>

Matthias, can you please stop sending these patches?  Gcc semantics
correctly are that static inlines can be unused and it's perfectly
fine.  It's your job to make clang fit that instead of spreading garbage
all over the kernel.