linux-kernel - Re: [PATCH] powerpc: sysdev: simple_gpio: fix Oops in gpio save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY4Y=Z7BVpeUxhYNdj815HQORo+TzfhbQATtbRMsurQLA@mail.gmail.com>
Date:   Mon, 29 May 2017 11:37:48 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Christophe Leroy <christophe.leroy@....fr>
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Scott Wood <oss@...error.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org list" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH] powerpc: sysdev: simple_gpio: fix Oops in gpio save_regs function

On Wed, May 24, 2017 at 10:01 AM, Christophe Leroy
<christophe.leroy@....fr> wrote:

> of_mm_gpiochip_add_data() generates an Oops for NULL pointer dereference.
>
> of_mm_gpiochip_add_data() calls mm_gc->save_regs() before
> setting the data, therefore ->save_regs() cannot use gpiochip_get_data()
>
> Fixes: 937daafca774b ("powerpc: simple-gpio: use gpiochip data pointer")
> Cc: stable@...r.kernel.org
>
> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Sorry for any screwups I've caused...

Yours,
Linus Walleij