linux-kernel - Re: KASAN vs. boot-time switching between 4- and 5-level paging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4f11000-6138-c6ab-d075-2c4bd6a14943@virtuozzo.com>
Date:   Mon, 29 May 2017 14:45:51 +0300
From:   Andrey Ryabinin <aryabinin@...tuozzo.com>
To:     Dmitry Vyukov <dvyukov@...gle.com>
CC:     "Kirill A. Shutemov" <kirill@...temov.name>,
        Alexander Potapenko <glider@...gle.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "x86@...nel.org" <x86@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, Andi Kleen <ak@...ux.intel.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Andy Lutomirski <luto@...capital.net>,
        <linux-arch@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kasan-dev <kasan-dev@...glegroups.com>
Subject: Re: KASAN vs. boot-time switching between 4- and 5-level paging



On 05/29/2017 02:19 PM, Dmitry Vyukov wrote:
> On Mon, May 29, 2017 at 1:18 PM, Andrey Ryabinin
> <aryabinin@...tuozzo.com> wrote:
>>
>>
>> On 05/29/2017 01:02 PM, Dmitry Vyukov wrote:
>>> On Sat, May 27, 2017 at 12:10 AM, Kirill A. Shutemov
>>> <kirill@...temov.name> wrote:
>>>> On Thu, May 25, 2017 at 11:33:33PM +0300, Kirill A. Shutemov wrote:
>>>>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>>>>> index 0bf81e837cbf..c795207d8a3c 100644
>>>>> --- a/arch/x86/Kconfig
>>>>> +++ b/arch/x86/Kconfig
>>>>> @@ -100,7 +100,7 @@ config X86
>>>>>       select HAVE_ARCH_AUDITSYSCALL
>>>>>       select HAVE_ARCH_HUGE_VMAP              if X86_64 || X86_PAE
>>>>>       select HAVE_ARCH_JUMP_LABEL
>>>>> -     select HAVE_ARCH_KASAN                  if X86_64 && SPARSEMEM_VMEMMAP
>>>>> +     select HAVE_ARCH_KASAN                  if X86_64 && SPARSEMEM_VMEMMAP && !X86_5LEVEL
>>>>>       select HAVE_ARCH_KGDB
>>>>>       select HAVE_ARCH_KMEMCHECK
>>>>>       select HAVE_ARCH_MMAP_RND_BITS          if MMU
>>>>
>>>> Looks like KASAN will be a problem for boot-time paging mode switching.
>>>> It wants to know CONFIG_KASAN_SHADOW_OFFSET at compile-time to pass to
>>>> gcc -fasan-shadow-offset=. But this value varies between paging modes...
>>>>
>>>> I don't see how to solve it. Folks, any ideas?
>>>
>>> +kasan-dev
>>>
>>> I wonder if we can use the same offset for both modes. If we use
>>> 0xFFDFFC0000000000 as start of shadow for 5 levels, then the same
>>> offset that we use for 4 levels (0xdffffc0000000000) will also work
>>> for 5 levels. Namely, ending of 5 level shadow will overlap with 4
>>> level mapping (both end at 0xfffffbffffffffff), but 5 level mapping
>>> extends towards lower addresses. The current 5 level start of shadow
>>> is actually close -- 0xffd8000000000000 and it seems that the required
>>> space after it is unused at the moment (at least looking at mm.txt).
>>> So just try to move it to 0xFFDFFC0000000000?
>>>
>>
>> Yeah, this should work, but note that 0xFFDFFC0000000000 is not PGDIR aligned address. Our init code
>> assumes that kasan shadow stars and ends on the PGDIR aligned address.
>> Fortunately this is fixable, we'd need two more pages for page tables to map unaligned start/end
>> of the shadow.
> 
> I think we can extend the shadow backwards (to the current address),
> provided that it does not affect shadow offset that we pass to
> compiler.

I thought about this. We can round down shadow start to 0xffdf000000000000, but we can't
round up shadow end, because in that case shadow would end at 0xffffffffffffffff.
So we still need at least one more page to cover unaligned end.