linux-kernel - Re: [PATCH v2 07/27] thunderbolt: Allow passing NULL to tb_ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1496060062.28981.15.camel@linux.intel.com>
Date:   Mon, 29 May 2017 15:14:22 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <yehezkel.bernat@...el.com>,
        Lukas Wunner <lukas@...ner.de>,
        Amir Levy <amir.jer.levy@...el.com>,
        Andy Lutomirski <luto@...nel.org>,
        Mario Limonciello <Mario.Limonciello@...l.com>,
        Jared.Dominguez@...l.com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 07/27] thunderbolt: Allow passing NULL to
 tb_ctl_free()

On Sun, 2017-05-28 at 11:13 +0300, Mika Westerberg wrote:
> On Sat, May 27, 2017 at 06:41:28PM +0300, Andy Shevchenko wrote:
> > On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg
> > <mika.westerberg@...ux.intel.com> wrote:
> > > Following the usual pattern used in many places, we allow passing
> > > NULL
> > > pointer to tb_ctl_free(). Then the user can call the function
> > > regardless
> > > if it has allocated control channel or not making the code bit
> > > simpler.
> > > 
> > 
> > +Suggested-by as you mentioned in cover letter?
> 
> OK, I'll add it.
> 
> BTW, should I do it for the other patch that was suggested by Andreas
> as
> well?

Sure


-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy