linux-kernel - Re: [PATCH v3 06/10] gpio: exar: Fix reading of directions and values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZeRQdM1RrPzqWnJOFiwbdgiGgzo_cVdMhgp2URriNJLQ@mail.gmail.com>
Date:   Mon, 29 May 2017 14:33:16 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jan Kiszka <jan.kiszka@...mens.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexandre Courbot <gnurou@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Sascha Weisenberger <sascha.weisenberger@...mens.com>
Subject: Re: [PATCH v3 06/10] gpio: exar: Fix reading of directions and values

On Fri, May 26, 2017 at 6:02 PM, Jan Kiszka <jan.kiszka@...mens.com> wrote:

> First, the logic for translating a register bit to the return code of
> exar_get_direction and exar_get_value were wrong. And second, there was
> a flip regarding the register bank in exar_get_direction.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij