linux-kernel - Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 May 2017 16:28:44 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Oleg Drokin <green@...uxhacker.ru>
Cc:     devel@...verdev.osuosl.org,
        Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Al Viro <viro@...IV.linux.org.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>,
        "John L . Hammond" <john.hammond@...el.com>
Subject: Re: [PATCH] staging/lustre/lov: remove set_fs() call from
 lov_getstripe()

On Fri, May 26, 2017 at 11:40:33PM -0400, Oleg Drokin wrote:
> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct
> lov_user_md pointer from user- or kernel-space.  This changes the
> behavior of copy_from_user() on SPARC and may result in a misaligned
> access exception which in turn oopses the kernel.  In fact the
> relevant argument to lov_getstripe() is never called with a
> kernel-space pointer and so changing the address limits is unnecessary
> and so we remove the calls to save, set, and restore the address
> limits.
> 
> Signed-off-by: John L. Hammond <john.hammond@...el.com>
> Reviewed-on: http://review.whamcloud.com/6150
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221
> Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>
> Reviewed-by: Li Wei <wei.g.li@...el.com>
> Signed-off-by: Oleg Drokin <green@...uxhacker.ru>
> ---
>  drivers/staging/lustre/lustre/lov/lov_pack.c | 9 ---------
>  1 file changed, 9 deletions(-)

So is this the patch that you want applied to the staging tree(s) as
well?  If so, please let me know, otherwise I have no clue...

Come on, you know better than this...

greg k-h