linux-kernel - Re: [PATCH 2/3] pinctrl: tegra: clean up modular vs. non-modular distinctions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYuEiCjGMHAg+sqh8OAqpoFqAByt+ZxLq2NssZSLO8ebw@mail.gmail.com>
Date:   Mon, 29 May 2017 10:25:21 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Stephen Warren <swarren@...dotorg.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Alexandre Courbot <gnurou@...il.com>,
        Pritesh Raithatha <praithatha@...dia.com>,
        Ashwini Ghuge <aghuge@...dia.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH 2/3] pinctrl: tegra: clean up modular vs. non-modular distinctions

On Mon, May 22, 2017 at 10:56 PM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> None of the Kconfigs for any of these drivers are tristate,
> meaning that they currently are not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the drivers there is no doubt they are builtin-only.  All
> drivers get similar changes, so they are handled in batch.
>
> We remove module.h from code that isn't doing anything modular at
> all;  if they have __init sections, then replace it with init.h.
>
> A couple drivers have module_exit() code that is essentially orphaned,
> and so we remove that.
>
> Quite a few bool drivers (hence non-modular) are converted over to
> to builtin_platform_driver().
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Stephen Warren <swarren@...dotorg.org>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Alexandre Courbot <gnurou@...il.com>
> Cc: Pritesh Raithatha <praithatha@...dia.com>
> Cc: Ashwini Ghuge <aghuge@...dia.com>
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-tegra@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Patch applied.

Yours,
Linus Walleij