linux-kernel - Re: [PATCH] gpio: davinci: Handle return value of clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZym6wTQJtueUG_CjzjUGvXGXPRpNbw3pBRmEYL5Ga2YQ@mail.gmail.com>
Date:   Mon, 29 May 2017 10:39:33 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Alexandre Courbot <gnurou@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: davinci: Handle return value of clk_prepare_enable

On Tue, May 23, 2017 at 11:18 AM, Arvind Yadav
<arvind.yadav.cs@...il.com> wrote:

> clk_prepare_enable() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Patch applied.

Normally we use goto's for the errorpath but in this case I see the
goto is used for positive exit in this driver so this solution is less
messy than adding another goto path.

Yours,
Linus Walleij