linux-kernel - Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 May 2017 16:04:45 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jork Loeser <Jork.Loeser@...rosoft.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Andy Lutomirski <luto@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB
 flush

On Tue, 30 May 2017 19:17:46 +0000
Jork Loeser <Jork.Loeser@...rosoft.com> wrote:

> > -----Original Message-----
> > From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> > Sent: Tuesday, May 30, 2017 09:53
> > To: Vitaly Kuznetsov <vkuznets@...hat.com>
> > Cc: x86@...nel.org; devel@...uxdriverproject.org; linux-
> > kernel@...r.kernel.org; KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> > <haiyangz@...rosoft.com>; Stephen Hemminger <sthemmin@...rosoft.com>;
> > Thomas Gleixner <tglx@...utronix.de>; Ingo Molnar <mingo@...hat.com>; H.
> > Peter Anvin <hpa@...or.com>; Steven Rostedt <rostedt@...dmis.org>; Jork
> > Loeser <Jork.Loeser@...rosoft.com>; Simon Xiao <sixiao@...rosoft.com>;
> > Andy Lutomirski <luto@...nel.org>
> > Subject: Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush
> > 
> > On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov <vkuznets@...hat.com>
> > wrote:  
> > > +#define HV_FLUSH_ALL_PROCESSORS                        0x00000001
> > > +#define HV_FLUSH_ALL_VIRTUAL_ADDRESS_SPACES    0x00000002
> > > +#define HV_FLUSH_NON_GLOBAL_MAPPINGS_ONLY      0x00000004
> > > +#define HV_FLUSH_USE_EXTENDED_RANGE_FORMAT     0x00000008  
> > 
> > BIT() ?  
> 
> Certainly a matter of taste. Given that the Hyper-V spec lists these as hex numbers, I find the explicit numbers appropriate.
> 
> Regards,
> Jork

Keep the hex numbers, it makes more sense not to change it since rest of arch/x86/hyperv
uses hex values.