linux-kernel - Re: [PATCH 2/3] zswap: Improve a size determination in zswap_frontswap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 May 2017 19:19:33 -0400
From:   Dan Streetman <ddstreet@...e.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Linux-MM <linux-mm@...ck.org>, Seth Jennings <sjenning@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/3] zswap: Improve a size determination in zswap_frontswap_init()

On Sun, May 21, 2017 at 4:26 AM, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 20 May 2017 22:44:03 +0200
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Acked-by: Dan Streetman <ddstreet@...e.org>

> ---
>  mm/zswap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 18d8e87119a6..a6e67633be03 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -1156,5 +1156,5 @@ static void zswap_frontswap_init(unsigned type)
>  {
>         struct zswap_tree *tree;
>
> -       tree = kzalloc(sizeof(struct zswap_tree), GFP_KERNEL);
> +       tree = kzalloc(sizeof(*tree), GFP_KERNEL);
>         if (!tree) {
> --
> 2.13.0
>