linux-kernel - Re: [PATCH 4/7] nvme: also report include the EUI-64 in identify NS report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebe7d06c-1839-3134-63c9-9360567b5a06@suse.de>
Date:   Tue, 30 May 2017 10:22:02 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Johannes Thumshirn <jthumshirn@...e.de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Keith Busch <keith.busch@...el.com>,
        Christoph Hellwig <hch@....de>
Cc:     Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>
Subject: Re: [PATCH 4/7] nvme: also report include the EUI-64 in identify NS
 report

On 05/30/2017 10:08 AM, Johannes Thumshirn wrote:
> Now that we can configure a namespace's EUI-64, report it back to the
> host in an 'Identify Namespace' command reply.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
> ---
>  drivers/nvme/target/admin-cmd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
> index ff1f97006322..60c9eec57986 100644
> --- a/drivers/nvme/target/admin-cmd.c
> +++ b/drivers/nvme/target/admin-cmd.c
> @@ -322,6 +322,7 @@ static void nvmet_execute_identify_ns(struct nvmet_req *req)
>  	id->nmic = (1 << 0);
>  
>  	memcpy(&id->nguid, &ns->nguid, sizeof(uuid_le));
> +	memcpy(&id->eui64, &ns->eui64, sizeof(ns->eui64));
>  
>  	id->lbaf[0].ds = ns->blksize_shift;
>  
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)