linux-kernel - Re: [PATCH 09/15] mfd: fsl-imx25: use devm_of_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170530093111.cw5d2gxfmcxtgl34@dell>
Date:   Tue, 30 May 2017 10:31:11 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Benjamin Gaignard <benjamin.gaignard@...aro.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/15] mfd: fsl-imx25: use devm_of_platform_populate()

On Mon, 29 May 2017, Benjamin Gaignard wrote:

> Use devm_of_platform_populate() to be sure that of_platform_depopulate
> is called when removing the driver.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>
> 
> CC: Lee Jones <lee.jones@...aro.org>
> CC: linux-kernel@...r.kernel.org
> ---
>  drivers/mfd/fsl-imx25-tsadc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
> index ac430a3..4258a42 100644
> --- a/drivers/mfd/fsl-imx25-tsadc.c
> +++ b/drivers/mfd/fsl-imx25-tsadc.c
> @@ -129,7 +129,6 @@ static void mx25_tsadc_setup_clk(struct platform_device *pdev,
>  static int mx25_tsadc_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
> -	struct device_node *np = dev->of_node;
>  	struct mx25_tsadc *tsadc;
>  	struct resource *res;
>  	int ret;
> @@ -178,9 +177,7 @@ static int mx25_tsadc_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, tsadc);
>  
> -	of_platform_populate(np, NULL, NULL, dev);
> -
> -	return 0;
> +	return devm_of_platform_populate(dev);
>  }
>  
>  static const struct of_device_id mx25_tsadc_ids[] = {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog