linux-kernel - Re: [PATCH 11/15] mfd: palmas: use devm_of_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170530093138.7bj5toutshey6bdv@dell>
Date:   Tue, 30 May 2017 10:31:38 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Benjamin Gaignard <benjamin.gaignard@...aro.org>
Cc:     Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/15] mfd: palmas: use devm_of_platform_populate()

On Mon, 29 May 2017, Benjamin Gaignard wrote:

> Use devm_of_platform_populate() to be sure that of_platform_depopulate
> is called when removing the driver.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>
> 
> CC: Tony Lindgren <tony@...mide.com>
> CC: Lee Jones <lee.jones@...aro.org>
> CC: linux-kernel@...r.kernel.org
> ---
>  drivers/mfd/palmas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> index 9103aff..3922a93 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
> @@ -676,7 +676,7 @@ static int palmas_i2c_probe(struct i2c_client *i2c,
>  	 * otherwise continue and add devices using mfd helpers.
>  	 */
>  	if (node) {
> -		ret = of_platform_populate(node, NULL, NULL, &i2c->dev);
> +		ret = devm_of_platform_populate(&i2c->dev);
>  		if (ret < 0) {
>  			goto err_irq;
>  		} else if (pdata->pm_off && !pm_power_off) {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog